search

StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 21 forks source link

Lock installer version #311

Closed emedvedev closed 8 years ago

emedvedev commented 8 years ago

To have installer versioning we have to lock it in the workroom st2.yaml along with the st2 version.

Untested, don’t merge for now.

emedvedev commented 8 years ago

Tested it, everything works, the right st2installer version gets pulled. All we need to do now is keep st2installer tags organized and change st2.yaml once a new version is released. Good to merge?

cc @lakshmi-kannan @dzimine

lakshmi-kannan commented 8 years ago

High level this looks ok. Where's the code that looks at this hiera variable and clones the appropriate branch? I want to take a look first.

emedvedev commented 8 years ago

Here's the hiera reading: https://github.com/StackStorm/st2workroom/blob/59b3e9dd62dd34e823203d0af6b7aa987e91fce7/modules/profile/manifests/st2server.pp#L25

And here's the branch checkout: https://github.com/StackStorm/st2workroom/blob/59b3e9dd62dd34e823203d0af6b7aa987e91fce7/modules/profile/manifests/st2server.pp#L943

lakshmi-kannan commented 8 years ago

LGTM. +1. Thanks for the pointers.

emedvedev commented 8 years ago

Woot.