In order to carve out a path for future development of this project, we need to make clear what this project is. It started as a way to fix an issue where a twitter link posted to discord would display in the embed a video that would display a message that it could not be played.

Discord Embedding

I think this problem has been fixed in Discord; but it is done in a strange way where Discord will first try to play using its own player, then when the player enters a failure state it appears that Discord attempts to load another playback mechanism, eventually falling back to Twitters own player in an element, so after three or so attempts to play the embedded video the play button will be twitters version and you have to press it again to start the video, this works on videos as long as these can be embedded, but the experience is strange given multiple presses of the play button and flickering state changes. </p> <h1>Not about videos no more</h1> <p>Other changes have been made to the TwitFix codebase in the past months and it appears that the overarching purpose is to provide a better embedding experience which better fits the live chat environment a given tweet is embedded into.</p> <ul> <li>Showing NSFW tweet images without suppression or leveraging the chat client spoilering mechanism.</li> <li>Show a different picture from a collection than the default.</li> <li>Collage the collection set into a new image that we host.</li> <li>Video preview image</li> <li>Fixing the video player reloading thing since that is still annoying.</li> <li>Rehost tweet content and prevent deletions from affecting links.</li> </ul> <h1>Forging ahead.</h1> <ul> <li>Which twitter links will we generate embeds for? </li> <li>Which chat clients will we support as targets for embeds?</li> <li>How do these clients support embedding? (do they handle twitter as a special case?)</li> <li>How will we format our embeds, and how will we fall back if another client is less capable?</li> <li>Will we rehost and transcode content to enable wider comparability?</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Deer-Spangle"><img src="https://avatars.githubusercontent.com/u/60626596?v=4" />Deer-Spangle</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I would like to add a vote for Telegram to be a supported target for embedding. Twitter embedding in telegram has been broken for some time, and folks started using fxtwitter. The only remaining issue I've seen on telegram, when using ayytwitter.com links, is that videos embed, but don't get the tweet text also</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/StormyDragon"><img src="https://avatars.githubusercontent.com/u/6131209?v=4" />StormyDragon</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Oh definitely; I'm currently setting up a bunch of experiments to probe what I'm able to do with the embed targets. They all seem to have different ideas of what to present, some even have overrides for specific websites.</p> <p>My goal is separating embed information for the various sites such that it is clear exactly which information we need to send them to generate a given embed and so that eventual changes to an embed system for one site does not give a bad experience for another.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/StormyDragon"><img src="https://avatars.githubusercontent.com/u/6131209?v=4" />StormyDragon</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@Deer-Spangle I've added the description field to the video embed, I checked in Discord and Telegram and it does not look like it had any adverse effects, let me know if it broke something.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Deer-Spangle"><img src="https://avatars.githubusercontent.com/u/60626596?v=4" />Deer-Spangle</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>It seems to work! Wow, thanks for the fast work there! I have noticed some gif tweets not working, but not sure whether they worked before (but they work with normal twitter.com links, and seem to work with other forks) An example: <a href="https://ayytwitter.com/Tangeluscious/status/1533257180379549697">https://ayytwitter.com/Tangeluscious/status/1533257180379549697</a> [technically sfw, but mature]</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/daisyUniverse"><img src="https://avatars.githubusercontent.com/u/12601774?v=4" />daisyUniverse</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>@Deer-Spangle I've added the description field to the video embed, I checked in Discord and Telegram and it does not look like it had any adverse effects, let me know if it broke something.</p> </blockquote> <p>in my experiments, adding the description field in videos only had a bad effect on specifically mobile discord embeds ( this is because of the whole no-descriptions-for-desktop-embeds bug, causing mobile embeds to use both the title tweet text and description field tweet text ) but if you are serving separate embeds specifically for telegram I would expect it to work fine</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/StormyDragon"><img src="https://avatars.githubusercontent.com/u/6131209?v=4" />StormyDragon</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Like this. Yup, I broke it. :></p> <p><img src="https://user-images.githubusercontent.com/6131209/172675349-63f67078-b13c-4b69-86a6-25f9fceecb0c.png" alt="image" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Deer-Spangle"><img src="https://avatars.githubusercontent.com/u/60626596?v=4" />Deer-Spangle</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Ah, whoops!</p> <p>It seems like we need a list of manual QA tests at the very least, a matrix of them I guess? Like, example tweets with videos, descriptions, single image, multiple images, gifs, text only, etc And then a list of clients: Discord desktop, discord web, discord mobile, telegram desktop, telegram mobile, telegram webk/webz? And then see what the support is like for each of them. I don't think we can really automate it, unfortunately. </p> <p>Does that sound handy? I could give it a go if you want</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/StormyDragon"><img src="https://avatars.githubusercontent.com/u/6131209?v=4" />StormyDragon</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I tried automating Telegram using <code>playwright</code> but it's being a quite a finicky beast. I think it would be a valuable information gathering exercise, which clients, variants, and which outputs do we actually generate.</p> <p>I'm working to have separate templates for each client such that we don't have to worry about weird oddities stepping over one another, instead of trying to fit everything into a single megatemplate that tries to meet the lowest common denominator.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Deer-Spangle"><img src="https://avatars.githubusercontent.com/u/60626596?v=4" />Deer-Spangle</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Yeah, I suspect automation would be finicky and unreliable, to be honest?</p> <p>Perhaps one could quite easily automate a small script that creates an tweet for each example, and sends them into a telegram chat or discord chat, that would be helpful (to ensure web preview isn't using a cached result) But as for checking, it feels like manually giving each link a peek in each client would be the most efficient way to go. A few minutes maybe, vs the maintenance burden of an e2e suite that relies on external applications. In the longer run, I would normally recommend test automation! But there is always the chance that discord and telegram actually buck up their ideas and get this stuff actually fixed on their end. So doesn't seem worth tooooo much to do test automation.</p> <p>And it sounds like generating a different template for telegram vs discord would be ideal, yeah!</p> <p>I wouldn't mind throwing together an example tweet creation script, and some testing playbook and little report table if you want. I would love to help out</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/StormyDragon"><img src="https://avatars.githubusercontent.com/u/6131209?v=4" />StormyDragon</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I will value all information that probes the capabilities of our target clients. :)</p> <p>We need to support:</p> <ul> <li>Text Tweets</li> <li>Image Tweets (single, multiple, specific)</li> <li>Video Tweets (single, multiple, specific) (I see references to multiple videos in single tweets, but I haven't seen a single one of them, maybe it is a lie)</li> <li>Place Tweet</li> <li>User Profile Tweet</li> </ul> <p>I think these are the potential tweets that are described in the API.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Deer-Spangle"><img src="https://avatars.githubusercontent.com/u/60626596?v=4" />Deer-Spangle</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Yeah, the API makes clear that tweets can have 1-4 images, or 1 video, or 1 gif. I'm sure I recall mention of multi-video tweets, but the API seems clear about it, and I've never seen proof of one when I try and find one.. I'm not sure their definition of gif either, to be honest. (I've spent a long time probing the limits of "gifs" for telegram, but maybe the twitter actually wants them uploaded as old fashioned .gif files. I can't find good data on that) I read of those place and profile tweets too, but haven't seen many around</p> <p>Okay, I'll try and whip up a script, at least</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

StormyDragon / TwitFix

What is TwitFix? #9

Discord Embedding