search

Storytel / react-redux-spinner

An automatic spinner for react and redux
https://storytel.github.io/react-redux-spinner/
MIT License
80 stars 13 forks source link

loading bar stays in view even after dispatching 'end' #7

Closed mandycandyqt closed 8 years ago

mandycandyqt commented 8 years ago

even after dispatching [ pendingTask ]: end loader stays in view. loader only leaves view once the horizontal bar reaches the right side of the screen. doesn't seem to coordinate with actual dispatch of end action.

noseglid commented 8 years ago

Well, it attempts to do a smooth animation indicating that the progress quickly reached 100%. Is this what you're referring to? What would you rather want happen?

mandycandyqt commented 8 years ago

i would expect that the animation is no longer visible once the success action fires. that the component updates its state while the loader remains executing to completion is awkward.

noseglid commented 8 years ago

I don't understand. It will be visible for a second or so until it's spun up to "full screen width". Once there, it will fade away. This is how nprogress works (which this spinner uses for animations.

Do you expect it to instantaneously disappear when end action is fired?