search

Storyyeller / Krakatau

Java decompiler, assembler, and disassembler
GNU General Public License v3.0
1.95k stars 219 forks source link

Add `Module` and `Package` tag types #193

Closed KOLANICH closed 1 year ago

KOLANICH commented 1 year ago

module-info.zip (taken from Google Closure Compiler jar (compiler_uberjar_deploy.jar) produced by CI (not the downloads on Maven) )

https://github.com/openjdk/jdk/blob/72de24e59a80a38ea4ea6a8a3f966f555987ac86/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java https://github.com/openjdk/jdk/blob/72de24e59a80a38ea4ea6a8a3f966f555987ac86/src/java.base/share/native/include/classfile_constants.h.template https://github.com/openjdk/jdk/blob/72de24e59a80a38ea4ea6a8a3f966f555987ac86/src/hotspot/share/classfile/classFileParser.cpp#L356-L366

It seems that the value is unused.

Haven't tested it on a full jar, but running it on the file provided (even with setting the classpath to the jar it is taken from) results in ClassNotFoundException: //module-info

Storyyeller commented 1 year ago

This is already supported in V2. I'm surprised that I didn't backport it already.