search

Storyyeller / Krakatau

Java decompiler, assembler, and disassembler
GNU General Public License v3.0
1.95k stars 220 forks source link

Maximum recursion depth #80

Closed samczsun closed 8 years ago

samczsun commented 8 years ago

This was a fun one to find. Likely system-independent but here's the assembly file I used

https://cloud.samczsun.com/f/25ad7e6277/

In javamethod.py

expr.params = map(simplify, expr.params)
Storyyeller commented 8 years ago

I guess I should add the limit on expression nesting back in? It's a bit of a dilemma, because in most cases, inlining expressions makes the resulting code more readable.

samczsun commented 8 years ago

Yeah, you could increase the stack size but that might lead to DoS vulns. Best solution might be to just have a counter