search

StoutLogic / acf-builder

An Advanced Custom Field Configuration Builder
GNU General Public License v2.0
792 stars 60 forks source link

Adding removeField and modifyField to GroupBuilder #91

Closed voyou-sbeaulieu closed 3 years ago

voyou-sbeaulieu commented 5 years ago

Hi! Keep on the good work! We use this logic for all our project now and since we use lots of group / flexible we ran into some problem with the remove / modifyField with groups.

Those functions were missing from the Group scope. linked to issue #82

stevep commented 5 years ago

Hey @voyou-sbeaulieu, finally getting around to making updates to the library. Can you add tests to the test suite for this? Just so in the future we don't break things. Thanks

voyou-sbeaulieu commented 5 years ago

@stevep Sorry for the late reply! Not very familiar with the tests? But I can tell you we already made about ~5 projects with this fix and they all work well no other alteration needed.

Just tell me where / what to test and I will surely do it as soon as possible!

Thank for your time!

marcelo2605 commented 3 years ago

@voyou-sbeaulieu Did you test this change using the latest version?

voyou-sbeaulieu commented 3 years ago

Hi!

So for the late delay on this ! I was on vacations.

Yes we still use this fix on the latest version I believe.

Le ven. 20 août 2021 18:45, Marcelo @.***> a écrit :

@voyou-sbeaulieu https://github.com/voyou-sbeaulieu Did you test this change using the latest version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/StoutLogic/acf-builder/pull/91#issuecomment-902994237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVLJ5RJ4SJTZD6ZK2RGU63T53LKFANCNFSM4H7OYB5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

marcelo2605 commented 3 years ago

Thanks for the reply @voyou-sbeaulieu. I added your changes on my end and try to modify a repeater subfield this way and also this way. But it still throw an error.

stevep commented 3 years ago

This has been released in version 1.12.0