StraboSpot / StraboSpot2

Rewrite for native.
MIT License
13 stars 1 forks source link

Unexpected Nested Strat Columns #630

Open andrewkrh opened 2 weeks ago

andrewkrh commented 2 weeks ago

Describe the bug When I make a new strat section any previous strat section in the dataset gets nested in the new spot. Perhaps this is intentional, given they are similar kinds of data, but this may not always make sense as you may be doing two completely different strat sections for very different reasons. For example, a section to describe the stratigraphy of Cretaceous units and a section to describe Quaternary sedimentation and geochronology. These wouldn't necessarily relate to each other.

To Reproduce Are you able to reproduce the problem in a new project after restarting the app? Yes

Steps to reproduce the behavior:

  1. Make a strat section geolocated by the spot at the base and add an interval
  2. Make a new strat section geolocated by a new spot at the base and add an interval
  3. view nesting behavior

Expected behavior I would like to be able to edit which spots are nested within other spots. Currently, I don't see a way to edit the nesting order or nesting relationships. Automatically nesting spots in a strat column might make sense for most, but having an ability to edit nesting would be nice.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

jessicagood commented 2 weeks ago

Fixed with commit 21b6cfbba7a468bc511f63461be37828a365f82e

The spots that are nested within other spots are fixed. It is based on geometry, as in a point in nested in a polygon, or by simply being a spot on an image basemap or strat section then it is nested within the parent spot. That being said, the calculations for determining nested spots were not correct. I was able to recreate the issue you've described and fix it. See if it is working better for you when the next version is released.