search

StractOrg / stract

web search done right
https://stract.com
GNU Affero General Public License v3.0
1.94k stars 43 forks source link

Old value of safe-search used when going back to "Search" #106

Open oeb25 opened 9 months ago

oeb25 commented 9 months ago

If one goes to the settings after performing a search, toggles safe-search, and then goes back to /search, then ?ss= is still set to the old value. However, any new search correctly uses the new value of safe-search.

This is in line what we expect when storing the query in sessions storage, but perhaps some parts of url.search should not be synced.

What are your thoughts on this?

mikkeldenker commented 9 months ago

That's a very good point. It would also cause confusion if the user deletes a site from liked or disliked sites, but the old sr is used. I think we should probably only sync the q, gl and optic parameters and build the rest from localstorage.