StractOrg / stract

web search done right
https://stract.com
GNU Affero General Public License v3.0
2.13k stars 47 forks source link

fix: update scrolls to auto #159 #160

Closed a0m0rajab closed 7 months ago

a0m0rajab commented 7 months ago

This fix fixes the extra scroll on the search page,

here is the before and after images:

Before on desktop: image

After desktop image

Before on Mobile: image

After mobile: image

Closes #159.

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

oeb25 commented 7 months ago

This seems entirely reasonable, and thanks for spotting this! Since I primarily develop on macOS where scroll and auto are almost equivalent, stuff like this slips through, so it's great that you went a head and fixed it!

LGTM! 🚀

mikkeldenker commented 7 months ago

Thank you!

a0m0rajab commented 7 months ago

You are welcome, I did not know that macOs @oeb25 logic for scroll and auto is the same. @mikkeldenker it's a great project looking forward to see how it will progress