StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
657 stars 49 forks source link

building:min_level of building:part is ignored #144

Open kayD opened 1 year ago

kayD commented 1 year ago

A building:part that specifies building:min_level is handled as if this attribute is ignored.

Expected behavior If for example a building:min_level=1 is specified, then the ground level should be empty/not filled.

Example 1 https://www.openstreetmap.org/way/1174378874#map=19/49.78869/9.93246 https://streets.gl/#49.78877,9.93248,45.00,17.57,89.69 image The goldenrod building part should only be level 1, level 0 (ground) should not be there.

Example 2 A two-floor building, level 0 should be white, level 1 should be brown. level 0: https://www.openstreetmap.org/way/1174541749 level 1: https://www.openstreetmap.org/way/1174541748 https://streets.gl/#50.49784,9.94346,45.00,0.00,112.93 image The brown top floor is rendered also for the ground floor, conflicting with the white colour.

Additional context Please note that this seems unrelated to the problem about rendering building outlines when building:part geometry is present, which is handled in #3 I do recall that this worked before, but not 100% sure any more.

kayD commented 9 months ago

I think this bug has been fixed in the meantime by @StrandedKitty: the location mentioned in the original post now looks like this: Screenshot_20240102_125506 Which is the expected rendering!