Open Tntnnbltn opened 10 months ago
There are example of situations where the wall face should be rendered, so any change should take this into consideration.
Are there existing tagging practices for indicating whether this face should be present or not? According to the diagram in Simple 3D Buildings § Terminology in the OSM wiki, it seems like the correct term for this wall face is "gable". Taginfo shows two tags that perhaps are used with this goal: roof:gable=yes/no
and building:gable_wall=yes/no
.
If I'm reading the Wikipedia article correctly, the former should represent only the triangular shape in the roof, using in the same material as the roof (so this would match the situation you illustrated above), whereas the latter would represent the entire wall extending upwards in a triangular shape to meet the roof, i.e. the triangle bit has the same material as the wall.
Does this sound correct to you?
When rendering certain roof types, such as gabled or skillion, a partial segment of wall is rendered with that shape, e.g. the triangular wall sements for a gabled roof, or a wedge shape for skillion. It also renders a face along the bottom of the object.
There are certain situations where it would be nice to be able to render the roof without this wall or bottom face, to reflect the appearance of the actual object. For example:
roof:shape=gabled:![image](https://github.com/StrandedKitty/streets-gl/assets/108752678/21acd816-e683-49c5-a1d5-ddc1b8c8fa70)
roof:shape=skillion:![image](https://github.com/StrandedKitty/streets-gl/assets/108752678/f8004aee-cd9e-4b12-bcc1-e5a247fc400e)
roof:shape=skillion (to the left):![image](https://github.com/StrandedKitty/streets-gl/assets/108752678/c05174cb-c60f-4fe9-8be7-1a9d1b69d910)
These shapes can be approximated in streets.gl already (despite having the partial wall face), but having the ability to control this would allow for more accurate rendering of objects. e.g. F4maps currently does not render any side walls if tagged as building:part=roof, which allows this veranda to be modelled.![image](https://github.com/StrandedKitty/streets-gl/assets/108752678/33ad9784-93c1-4973-810f-5f94a9017a2c)
Possible existing tags that could be used to guess author intent include:
Note: There are example of situations where the wall face should be rendered, so any change should take this into consideration.![image](https://github.com/StrandedKitty/streets-gl/assets/108752678/862d53aa-aa20-4f7d-b371-50ad9afbb842)