search

StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
632 stars 48 forks source link

roof goes through building #18

Closed ivanbranco closed 1 year ago

ivanbranco commented 1 year ago

I have a problem with this relation (Streets GL URL), I don't understand if I did something wrong or if is a problem with the renderer.

The last floor (the second: way252607457) is min_height=3 + height=5.7 the roof is min_height=5.7 + height=8.7 (w247047014)

shouldn't this be fine?

image

StrandedKitty commented 1 year ago

Thank you for reporting this. The problem was that this roof doesn't have a height tag, and default roof height didn't take into account building height and min_height.

Fixed in https://github.com/StrandedKitty/streets-gl/commit/400e0fc4d94569fb7e5e338baeaf1eb095667cac.

ivanbranco commented 1 year ago

Thank you for fixing it!

The problem was that this roof doesn't have a height tag,

I don't understand tho, the roof building:part does have height=8.7, why you say it doesn't?

StrandedKitty commented 1 year ago

Sorry, I was referring to roof:height. The roof (https://www.openstreetmap.org/way/247047014/history) doesn't have this tag so the renderer needs to guess.

ivanbranco commented 1 year ago

Uhm, I understand its use when a building/building:part has a facade and a roof. But with building:part=roof there's no facade, that's why I used height only. Thanks for the explanation

StrandedKitty commented 1 year ago

Hmm, I guess you are right. I didn't think of it this way. So many edge cases...