search

StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
661 stars 49 forks source link

Roof shading issues #36

Closed waldyrious closed 1 year ago

waldyrious commented 1 year ago

I'm not sure what exactly might be causing this, but the roof sharing in these buildings is inconsistent for some reason:

0x49zaf4ic

Link to the location: https://streets.gl/#16.67498,-22.93461,35.50,332.50,420.15

ivanbranco commented 1 year ago

I'm not sure what exactly might be causing this, but the roof sharing in these buildings is inconsistent for some reason:

Some of these building have roof:orientation=*, some don't. Could be that?

EDIT: Yep, the ones with shadows have roof:orientation=across, the ones without shadows don't.

StrandedKitty commented 1 year ago

Thank you for spotting this issue. There was a problem with UVs for OrientedGabledRoof (a gabled roof with roof:orientation).

I've fixed it in https://github.com/StrandedKitty/streets-gl/commit/22a94de2a074402d93373402db193b9741f26c0d. Hopefully, it's gonna work fine now.

Screenshot 2023-05-04 at 13 21 18
waldyrious commented 1 year ago

Nice, thanks for the quick fix! Just for reference, linking another thread discussing roof lighting issues: #50.