StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
660 stars 49 forks source link

some small building parts not rendered #48

Closed RedAuburn closed 1 year ago

RedAuburn commented 1 year ago

maybe this is due to way simplification? ideally, simplification wouldn't completely remove a building:part

F4Map / StreetsGL bitmap (slight roof difference due to F4Map being out of date)

https://www.openstreetmap.org/way/297997038

RedAuburn commented 1 year ago

Seems like simplifyNodes should be improved to take the area of the shape into account?

https://github.com/StrandedKitty/streets-gl/blob/22a94de2a074402d93373402db193b9741f26c0d/src/lib/tile-processing/tile3d/providers/Tile3DFromVectorProvider.ts#L191-L193

with no simplification: Screenshot from 2023-05-04 17-57-19

StrandedKitty commented 1 year ago

Fixed in https://github.com/StrandedKitty/streets-gl/commit/ff50ab974c07d5cb0d1c3d1c101fd8dc4b7b92ad.

ivanbranco commented 1 year ago

Uhm, something seems wrong here: image

The black parts are not connected with the platform

RedAuburn commented 1 year ago

i think this is because each building part gets its own offset from the sloped terrain, as opposed to getting one offset from the main building area and using it for all the contained building parts. But it's best to make a new issue for this :)

another example: https://streets.gl/#51.51475,-0.09843,20.50,354.50,415.75 image