Trees appear too bulky in some places on the map

ivanbranco commented 1 year ago

I wanted to take a look of how Streets GL rendered the Gundam (F4 for comparison here):

But trees cover it:

Based on aerial imagery F4 looks more similar to reality (Bing imagery): maybe trees should be smaller by default? In my city also they look too bulky

p.s. have you considered enabling "Discussions" (e.g. https://github.com/streetcomplete/StreetComplete/discussions/) so we can discuss things there are not proper bugs?

c-h-r-i-s-t-i-a-n commented 1 year ago

Is the height - value on trees evaluated in streets.gl?

StrandedKitty commented 1 year ago

Is the height - value on trees evaluated in streets.gl?

Yes, it is supported for individual trees and tree rows.

ivanbranco commented 1 year ago

A 953m tree compared to normal trees

sekerob commented 1 year ago

Who actually maps trees and rows with (estimated) heights and diameters? I don't, never ever, not encountered a natural / monumental tree that warrants the effort. Species could tell a little, orchard olives are 5-6m at best. Those street side certainly are pruned, all branches chopped to at least 5m from ground. Pines in the city usually have only the crown and in fact the Riserva Naturale Pineta here shows old to very old, only crown. Just added levels to apartment blocks on Via del Santuario, 7 at left, 5 at right, the pines lining the streets are reaching the top of the 4th floor.

PS for the exercize added height 13 to the pine tree rows to see the effect,

Edit: Change after adding estim.heights and solar panels on left bottom church roof, mapped as areas, tagged with location=roof (would be nice if those rendered).

westnordost commented 1 year ago

A 953m tree compared to normal trees

It's the mana tree from Secret of Mana! ;-)

Anyway, I compiled a small list of tags interesting for rendering in streets-gl from the information in the wiki in the hopes that this summary will be useful:

Size

Your tree models are roughly 1:2, i.e. double as high as wide. So:

use height, if not set est_height for height
use diameter_crown for width (height ~= width * 2)

circumference of the trunk is set on a lot of trees, because it is easy to measure on foot (may even be a StreetComplete quest one day). diameter also exists. diameter = circumference / PI. A very rough estimate would be diameter_crown = diameter * 30. Hence:

otherwise use diameter to estimate width
otherwise use circumference to estimate width

Trees in natural=orchard and landuse=plant_nursery + plant=<various> are always rather small and have mostly identical size.
Trees in natural=tree_row have very similar sizes
Trees in unmanaged woods have very very uneven sizes: natural=woods (and/or managed=no)
Trees in managed forests have quite even sizes, sometimes even planted in rows landuse=forest, espially with produce or operator. natural=woods with managed=yes also possible

Type of tree

for basic appearence: leaf_type=needleleaved or leaf_type=broadleaved
use leaf_cycle to havve deciduous trees not have leaves in winter
use leaf_cycle to fall back to a best guess if leaf_type is not specified

Specific models for specific trees

(Over the top / blue sky:)

For certain (families of) trees with specific appearance that are often used as , I guess you need to look in any of genus, species, species:wikidata, taxon and even species:<language>, genus:<language> to find which tree is which with best coverage. Examples of trees with a special look and that are used often in cities from the top of my head:

palm trees
cherry trees (pink blossom in spring)
apple trees (white blossom in spring)
orange, lemon trees (etc.) (quite distinct due to the many fruits in the tree)

However, I think such detection would warrant a separate library project that heavily makes use of wikidata data best written in a language that can compile to various targets (JS, native, ...), e.g. in Kotlin or Rust. Such a library project could then maybe also make predictions on the width, height, relation to trunk diameter etc.

benoit-dd commented 1 year ago

I think that most tree height are integrated from opendata bases (for exemple in Paris: this tree comes probably from this database)

Another funny example nearby: https://www.openstreetmap.org/node/5234550067#map=19/48.89506/2.31063 key	value
height	60
leaf_type	broadleaved
min_height	57
natural	tree

It has probably been tagged so to look fine in f4map. but it's probably a pretty rare case

I think location=roof+height=3 would be a better tagging and that it should give the same result.

About sekerob comment on solar panel, I think location=roof should be used to put whatever (trees, pools, pitches,solarpanels?) on top of roofs (should it be a separate issue)?