StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
604 stars 45 forks source link

Some roof normals seem incorrect #50

Closed RedAuburn closed 1 year ago

RedAuburn commented 1 year ago

these sides of the roof should be in shadow, maybe the normals are being smoothed?

https://streets.gl/#51.47754,-0.06461,27.50,280.00,1015.51 Screenshot from 2023-05-04 18-42-57

RedAuburn commented 1 year ago

The tiles normal map looks like it could be in world-space or something.

Without the current normal map, it looks better. But it still looks like the geometry normals on the roof ridge aren't right: with current normal map / without (better) bitmap

RedAuburn commented 1 year ago

another case: image https://streets.gl/#51.47754,0.01439,14.50,295.75,175.26

StrandedKitty commented 1 year ago

Hmm, it's hard to say whether it's expected behaviour or not. Maybe the normal map is a bit too extreme.

StrandedKitty commented 1 year ago

Normal texture for roof tiles had a slight slope baked into it. It should be better now. But besides this normal maps work correctly.