StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
604 stars 45 forks source link

roof:orientation don't work with roof:shape=gambrel #55

Closed Kazing closed 1 year ago

Kazing commented 1 year ago

Hello, thanks for this great renderer!

I think there is a bug with handling of roof:orientation=across

roof:shape=gambrel with roof:orientation=across no working ❌

https://streets.gl/#50.28689,2.78761,43.50,25.75,87.05 https://www.openstreetmap.org/way/144235322

image

The roof ridge is along the longer side, it should be across the longer side with roof:orientation=across tag

roof:shape=gabled with roof:orientation=across work well ✅

https://streets.gl/#50.28747,2.78603,41.00,351.50,123.96 https://www.openstreetmap.org/way/1110541653

image

RedAuburn commented 1 year ago

off topic, but how did you select the building? i didn't know you could do that

ivanbranco commented 1 year ago

off topic, but how did you select the building? i didn't know you could do that

Just a left click, doesn't it work for you?

StrandedKitty commented 1 year ago

Implemented in https://github.com/StrandedKitty/streets-gl/commit/cf53d5fae1c4ea9981c44edc4e85f1426b932a74.

Screenshot 2023-05-07 at 14 15 52