StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
604 stars 45 forks source link

Surface for streets and footways #56

Open Matthias84 opened 1 year ago

Matthias84 commented 1 year ago

Hi, can you support different materials for streets or highways? At the old cities there are usually (different) cobblestones which give a specific look. Similar the paved footway areas at the promenades or the wood steps at the beach :smile: Like the windows or glass material shaders, this might add some realism and support the recognition of a spot.

westnordost commented 1 year ago

Are the window fronts really shaders, or just textures?

@StrandedKitty since you get this flood of feature requests now, an advice: Start a CONTRIBUTING.md and link it from the README.md soon. This helped loads in the early days (and to this day) in StreetComplete to channel the interest in the project into productive contribution. A contribution guide brings great value to a project that pays off over time, and can be extended over time. For example, in this case, if you are looking for textures, you could write there what kind of textures you expect: the size, the license, the lighting, normalmaps or bumpmaps + more and most importantly, the overall style (realistic/photo, clean look, etc...). From the current screens it looks like you are going overall for a clean "Cities Skylines" sort of look?

Even if people didn't read this guide before posting an issue or a PR, you can simply point to the guide in the case that the contribution needs to be changed before being merged instead of repeating again and again what you think they should look like (or closing it without comment and appearing rude)

(The same for contributing 3D models for example. @tordanik has had a huge interest in 3D representation of OSM data, I think he had his hands in various attempts to create some sort of repository for models. Some/many models could be sourced from osm2world, which is still active)

StrandedKitty commented 1 year ago

@westnordost Thank you, indeed it would be nice to have some sort of a quide/list of rules for contributions.

ntzm commented 1 year ago

It would be great to support surface:colour, cycleway:surface:colour, etc. too!

hungerburg commented 1 year ago

A suggestion for highway=path, nearly half have surface=unpaved|ground, c.f. https://taginfo.openstreetmap.org/tags/highway=path#combinations - track material should do for them? Those might default to width 1m too?

Footways