search

StrandedKitty / streets-gl

🗺 OpenStreetMap 3D renderer powered by WebGL2
http://streets.gl
MIT License
604 stars 45 forks source link

roof:shape=round not shown #62

Closed cebderby closed 1 year ago

cebderby commented 1 year ago

Currently not showing roof:shape=round. Spec has never been clear what to do if roof:height is not exactly half the relevant width but half an ellipse is probably ok for general case. Is orientation = across/along (like gabled) to specify width vs length direction choice.
Some example locations here: https://streets.gl/#51.51294,-0.12221,40.25,222.00,123.70 (half round front) https://streets.gl/#53.47602,-2.24705,39.00,246.25,357.24 (large rather shallow one) https://streets.gl/#53.47695,-2.22934,29.75,307.50,346.27 (set of 4 side by side on building:part=roof)

StrandedKitty commented 1 year ago

Round roofs implemented in https://github.com/StrandedKitty/streets-gl/commit/cf53d5fae1c4ea9981c44edc4e85f1426b932a74.

Screenshot 2023-05-07 at 14 18 17
sekerob commented 1 year ago

Still not showing, maybe because I give them a roof:colour=lightgrey.

image Also noticed the oddest flickering only showing partial with the terrain elevation disabled. image

The position as shown in standard Carto. A link to the building for the tagging. https://www.openstreetmap.org/way/1167703980 image