search

StrandedKitty / three-csm

☀️ Cascaded shadow maps (CSMs) implementation for Three.js
MIT License
296 stars 21 forks source link

`breaks - 1` should be `breaks.length - 1`? #15

Closed jhurliman closed 2 years ago

jhurliman commented 2 years ago

https://github.com/vHawk/three-csm/blob/3f1ec07ef0248c774cbeaa9134f595c6c906aa34/src/Frustum.js#L113

Should this be breaks.length - 1? It looks like breaks is meant to be an array here.

StrandedKitty commented 2 years ago

Thanks, this typo didn't really break anything and I guess that's why I didn't notice it. Fixed in c3e334929bdbdb77d9d9e4f102b12dd4474b18d9