StrandedKitty / three-csm

☀️ Cascaded shadow maps (CSMs) implementation for Three.js
MIT License
296 stars 21 forks source link

Minor bugfixes: add lightColor, allow non-CSM light sources #32

Closed mjurczyk closed 1 year ago

mjurczyk commented 1 year ago

Small bugfixes for 2 long-standing issues:

Solves #13

Changes:

Solves #10

Changes:

beliarek (left - CSM directional light; right - another directional light; no more WebGL errors thrown on directionalLights loop)

StrandedKitty commented 1 year ago

Hi, thank you for this PR! I like your solution for differentiating CSM light sources from regular light sources in the shader.

I've committed some minor fixes, if everything looks okay to you then I will merge it.

mjurczyk commented 1 year ago

anya-forger-anya-spy-x-family-anime

LGTM