search

Strange18 / tcioe-node

1 stars 7 forks source link

iframe #159

Closed ompiepy closed 9 months ago

ompiepy commented 11 months ago

PDF should be embedded within the website, Currently we have to click to open in next tab Design was ready.

khemrajshrestha471 commented 10 months ago

Let me do this @ompiepy ...

ompiepy commented 10 months ago

Thanks, @khemrajshrestha471 .

khemrajshrestha471 commented 10 months ago

@ompiepy where can we find the design for that?

ompiepy commented 10 months ago

@bikrantbdr You worked on this before right? Can you help Khemraj.

bikrantbdr commented 10 months ago

I had already made the page, the iframe embedding was a problem so i had to redirect the pdf to a new tab temporarily, we can solve the issue if we can figureout why iframe component was not working properly

ompiepy commented 10 months ago

We need to figure out that problem.

ompiepy commented 10 months ago

PR #176 solves the embedding. Thanks, @khemrajshrestha471 and @bikrantbdr . Closing this.

ompiepy commented 10 months ago

PR #179 #180 #181 #182 #183 Solves this for PC. @khemrajshrestha471 Keep working the better solution for the mobile view. We will starting using this code to view in other places too. Thank you.

ompiepy commented 9 months ago

PR #194 #195 #196 Solves this for mobile view. Thanks @khemrajshrestha471. A special thank you to our friend, Niyoj Oli for working on the PDF Viewer Component,