StrangeLoopGames / EcoIssues

131 stars 21 forks source link

[QoL] Prevent plants(w\o seeds) from accidental eating #10076

Closed elfl0rd closed 5 years ago

elfl0rd commented 5 years ago

In current state, if you accidentally hover over an already planted plant and try to plant - you eat it. it's terribe... 20181120094403_1

Deantwo commented 5 years ago

I believe you can eat seeds too, so bad for those too.

Maybe "right-click to eat selected" is bad for all seed/plantable things. But if those are excluded we get inconsistency between how to eat different food items, so maybe the whole "right-click to eat selected" is just a bad idea in general.

The only reason I can think to have "right-click to eat selected" is because that is how you eat in Minecraft. So why not just get rid of it? I don't believe we have any other items that you use on yourself by right-clicking with them selected.

elfl0rd commented 5 years ago

as I see, you don't eat seeds when you look at a plant.

Deantwo commented 5 years ago

Maybe there is a small "if calories is 0, then don't eat" check? That just seem silly.

Being about to "right-click to eat selected" also create confusion when carrying "carry items" or when right-clicking a storage to place the selected item into it.

elfl0rd commented 5 years ago

but how do you propose to eat? If you remove the eating from the plants on the right mouse button, it will make it impossible to start the game.

Deantwo commented 5 years ago

@elfl0rd, you just right-click the food items with the mouse curcor instead? Like I said, the only reason I can see to keep the "right-click to eat selected" is because that is how it works in Minecraft.

Eco currently has it very consistent that right-clicking is used to place carried blocks (with selected tool), or add selected item to the storage or project of targeted object. Eating your selected item instead of placing it is inconsistent with that behavior.

elfl0rd commented 5 years ago

However, fast eating without turning cursor on is quite convenient. I think to start is to disable eating if the cursor is induced at something and see the result.

Nicolausi113 commented 5 years ago

What about this: whenever an eatable food is selected in the hot-bar, the background of nutrition window is highlighted, meaning you can eat one peace of the selected object by left-click in nutrition window? A total new procedure, I know, but could bring back consistency with right-click.

elfl0rd commented 5 years ago

However, you will need to release the mouse cursor, hover mouse cursor to it and click. It's harder and less obvious than eating with a right click directly from a Hotbar.

TemporalWolf commented 5 years ago

Making it a long click (half a second maybe?) to eat would fix the problem... and even then gives an opportunity for an eating animation... if you don't hold it long enough, you don't it eat.

elfl0rd commented 5 years ago

Making it a long click (half a second maybe?) to eat would fix the problem... and even then gives an opportunity for an eating animation... if you don't hold it long enough, you don't it eat.

Excellent idea! You hold rmb, character (animation) grab food, brings to mouth and bites. If you release rmb before bites - eating stops.

Quadbro commented 5 years ago

Sounds like a new QoL tweak?) ^_^, heh, late a bit, you changed label earlier)

elfl0rd commented 5 years ago

This more QoL than issue as I believe :)

Quadbro commented 5 years ago

and it's harder, because now (correct me if i'm wrong) there are no "hold button for X sec to do smth" mechanics in eco, i mean it's not used anywhere ...