search

StrangeLoopGames / EcoIssues

131 stars 21 forks source link

Unclaim all Properties is Spammy #12122

Closed Deantwo closed 4 years ago

Deantwo commented 5 years ago

The SeaOtter server has 585 total player, the majority of which aren't active in the world anymore. We have a periodic law that unclaims the properties of all players that have been offline for more than 8 days.

This is what happens when the law triggers: 2019-04-27 12_18_33-Window It goes on for a long time while it cycle through each player that meet the law's condition. Like a few hundred players, and each action seem to take a few seconds.

The issue is that it doesn't seem to check if those players even have any properties before attempting to unclaiming them and it gives a notification rather they had anything unclaimed or not. Seeing this notification for players that don't have any properties is just annoying.

See also: #10121

Deantwo commented 5 years ago

Would be nice if this notification message was sent in the "Property" channel too, rather than the "Notification" channel.

D3nnis3n commented 5 years ago

Removing suggestion label, this is annoying behaviour that can take up to half an hour in occuring. There needs to be a check for if someone has property before doing that, i consider that a bug.

@SlayksWood

WeaselDog commented 4 years ago

This is fixed now: FixedLawSpam

You can hold mouse over to see who was affected and the end result.

Also you can unclaim people the moment they become inactive instead of doing it every 24 hours.

D3nnis3n commented 4 years ago

How that for taxes? Would make sense, too.

WeaselDog commented 4 years ago

Works for taxes too and gives you a notification who could afford to pay, but this is just on an executive actions. It actually still needs to be applied to laws based on a timer that use each citizen, so it is not ready to close:

LawTimer

olegshegai commented 4 years ago

Yeah, I was exploring this topic today and wanted to leave a feedback later Civics-related stuff was refactored and greatly improved by @johnkslg I will reassign this issue since I am not the one who fixed it

olegshegai commented 4 years ago

RE: Taxes Taxes have some problems at the moment. And it's a case for another issue I suppose.