search

StrangeLoopGames / EcoIssues

131 stars 21 forks source link

[0.8.2.0 staging-10-n] Old Growth Redwood can overlaps with another tree. #12356

Open SlayksWood opened 5 years ago

SlayksWood commented 5 years ago

Need some more space between two Old growth Redwood. Generate new world after https://github.com/StrangeLoopGames/Eco/pull/4465 image image image

SlayksWood commented 5 years ago

image

SlayksWood commented 5 years ago

Old Growth Redwoods appear in one point very closely and some double in new world. image

SlayksWood commented 5 years ago

image

SlayksWood commented 5 years ago

image

SlayksWood commented 4 years ago

Still can overlap image

MazonDel commented 4 years ago

The current solution to this issue is in the branch titled "Bug-11142-Implementation". It was branched off of the "Develop" branch on 7/28/2020.

This adds a "Width" parameter to trees and alters the IsGoodPlacement() method to check the surrounding Blocks for validity conditions (ex: If there is empty space, that is not allowed. If there's a plant/tree there, that's not allowed.). In addition, this adds the IsGoodPlacement() check to the WorldLayerManager.PostWorldGenPlants() method, which did not previously check if the position was valid for the plant in question.

Note: To implement these features you will need to add a Width parameter to the trees in the EcoTechTree CSV, or (temporarily) manually add the width parameter to the relevant tree classes.

Note: This implementation can be used to solve bug https://github.com/StrangeLoopGames/EcoIssues/issues/11142 as well.