StrangeLoopGames / EcoIssues

131 stars 21 forks source link

0.9 potential griefing exploit with new "deed transfer" function. #13597

Closed elfl0rd closed 4 years ago

elfl0rd commented 4 years ago

Find any player who hasn't played for a long time. It is better if it is someone from the attacked settlement.

then take a cart, load it with tailings. изображение

Then deliver it to the place, rename deed, cart, and pass it deed to the absent player.

Fine. Without a deep check, it looks like this player who decided to do the nasty thing. изображение

I suggest the following. As in real life, it is not enough to "give" something You need a second person to accept the gift. Until a "deed" gift is accepted, the donor may cancel the gift. In the interface during the transfer process the owner is displayed as "A in transfer to B", where A is the original owner, B is the one to whom the gift is given.

SlayksWood commented 4 years ago

But Truck name is still mine. image

elfl0rd commented 4 years ago

you can rename it before deed transfer.

Then deliver it to the place, rename deed, cart, and pass it deed to the absent player.

SlayksWood commented 4 years ago

and it will rename after reload game

elfl0rd commented 4 years ago

and it will rename after reload game

After cache clean for existing players at renaming moment. (If you solo or etc - no problems.) Also this is not "issue" you can rename in advance изображение As you can see, this is test client cart filled by tailing :)

johnkslg commented 4 years ago

Made it so you can only change vehicle owners on your property. image

It will be good to eventually add an 'accept' action, because that could also be important for property taxes, etc. We can open a separate bug for that and push to post-9

elfl0rd commented 4 years ago

Exploit is not solved, because you can easily claim a piece of land next to the "enemy" and "pass" the cart there. Then you can just unclaim. And ofc, you can little move cart by push\world block placing.

johnkslg commented 4 years ago

Yes, will have to live with this till we can make an acceptance system, which will be a larger feature. But doable.

elfl0rd commented 4 years ago

Okay, i made feature request for it - https://github.com/StrangeLoopGames/EcoIssues/issues/14005

beastyn commented 4 years ago

I have a crush with deed transfer now. Will ,ake separate issue