StrangeLoopGames / EcoIssues

131 stars 21 forks source link

Laws: Location conditions available for actions without location #13876

Closed mirasrael closed 4 years ago

mirasrael commented 4 years ago

I.e. for PolluteAir action (which doesn't implement IPositionGameAction it still allows to add Location related conditions).

image

D3nnis3n commented 4 years ago

Fix should be to make it possible, not removing the location. Pollution Districts and Non-Pollution districts are typical use. (Think of industrial zoning IRL)

mirasrael commented 4 years ago

For Air Pollution it doesn't make real difference where pollution happens, because it is global. And we can't use aggregating stats effectively for air pollution if they will have Location.

D3nnis3n commented 4 years ago

If course it does. Local air pollution causes local ground pollution. Its also means of city zoning.

Alexander Bondarev notifications@github.com schrieb am Mo., 25. Nov. 2019, 11:55:

For Air Pollution it doesn't make real difference where pollution happens, because it is global. And we can't use aggregating stats effectively for air pollution if they will have Location.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StrangeLoopGames/EcoIssues/issues/13876?email_source=notifications&email_token=AGFVK4EVTFPSIIEAQ5ATNDDQVOVLDA5CNFSM4JRF24CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFB7OAA#issuecomment-558102272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFVK4ARCZTCT7ZESOQA4TTQVOVLDANCNFSM4JRF24CA .

mirasrael commented 4 years ago

OK. You're right. It is second order reaction when rain happens in are with air pollution then it makes ground pollution. We still may be fine if we will only restrict action in specified location, but won't allow to make historical queries for location (i.e. you can only allow to pollute air in specified district, but you can't deny to pollute air if user already performed some amount of pollution in specific area). There also a problem with location restrictions for air pollution, because vehicles produces pollution. So if you deny to pollute in some area then as soon as vehicle enter the area it will stop working. And you won't be able to leave the area on vehicle.

D3nnis3n commented 4 years ago

The laws i plan actually are supposed to restrict it based on tables not on cars. Is taxing for co2 amounts still possible even if we do not save data? CO2 tax was very common when pollution actually was a Thing pre 8.0. Now noone does it cause its not needed, but if 9.0 will have dangerous pollutions again, we need effective measures to keep it down. For example taxing outputted pollution based on amount. Otherwise there is little you can actually do to regulate pollution.

Believe me more saved data and more lag is the last i want, but if pollution is actually is actually a threat again that can even lead to a underwater world, players must be given some effective Regulation Tools. Everyone knows it wont work by common sense and agreements in most servers, especially as Big ones as our officials.

Alexander Bondarev notifications@github.com schrieb am Mo., 25. Nov. 2019, 13:32:

OK. You're right. It is second order reaction when rain happens in are with air pollution then it makes ground pollution. We still may be fine if we will only restrict action in specified location, but won't allow to make historical queries for location (i.e. you can only allow to pollute air in specified district, but you can't deny to pollute air if user already performed some amount of pollution in specific area). There also a problem with location restrictions for air pollution, because vehicles produces pollution. So if you deny to pollute in some area then as soon as vehicle enter the area it will stop working. And you won't be able to leave the area on vehicle.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StrangeLoopGames/EcoIssues/issues/13876?email_source=notifications&email_token=AGFVK4EQDELUKABM3JAYISDQVPAVJA5CNFSM4JRF24CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCHPZI#issuecomment-558135269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFVK4GKLMMKRUHI2YWXWGLQVPAVJANCNFSM4JRF24CA .

D3nnis3n commented 4 years ago

Tax had to be done by craft tax for each single item pre 8.0. Very, very exhausting. Thats why a real co2 tax would make stuff so much easier. Just tax co2, bot each item that creates co2.

Dennis Scholz scholzden@gmail.com schrieb am Mo., 25. Nov. 2019, 13:37:

The laws i plan actually are supposed to restrict it based on tables not on cars. Is taxing for co2 amounts still possible even if we do not save data? CO2 tax was very common when pollution actually was a Thing pre 8.0. Now noone does it cause its not needed, but if 9.0 will have dangerous pollutions again, we need effective measures to keep it down. For example taxing outputted pollution based on amount. Otherwise there is little you can actually do to regulate pollution.

Believe me more saved data and more lag is the last i want, but if pollution is actually is actually a threat again that can even lead to a underwater world, players must be given some effective Regulation Tools. Everyone knows it wont work by common sense and agreements in most servers, especially as Big ones as our officials.

Alexander Bondarev notifications@github.com schrieb am Mo., 25. Nov. 2019, 13:32:

OK. You're right. It is second order reaction when rain happens in are with air pollution then it makes ground pollution. We still may be fine if we will only restrict action in specified location, but won't allow to make historical queries for location (i.e. you can only allow to pollute air in specified district, but you can't deny to pollute air if user already performed some amount of pollution in specific area). There also a problem with location restrictions for air pollution, because vehicles produces pollution. So if you deny to pollute in some area then as soon as vehicle enter the area it will stop working. And you won't be able to leave the area on vehicle.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StrangeLoopGames/EcoIssues/issues/13876?email_source=notifications&email_token=AGFVK4EQDELUKABM3JAYISDQVPAVJA5CNFSM4JRF24CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCHPZI#issuecomment-558135269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFVK4GKLMMKRUHI2YWXWGLQVPAVJANCNFSM4JRF24CA .

johnkslg commented 4 years ago

Youll be able to tax pollution yep. For cars shutting off when you drive into non-pollution zone.. thats an interesting problem. Servers would need to setup a buffer for that not to happen. I think we allow it!

johnkslg commented 4 years ago

Fixed

Not shown with 'timer' action image

Shown with 'claim' action image

D3nnis3n commented 4 years ago

Not fixed, John. Location needs to be available for Timers too. How to regularily tax people in your rich district? Or in capital?

johnkslg commented 4 years ago

Added to timer. image