search

StrangeLoopGames / EcoIssues

131 stars 21 forks source link

Trade/Store menu duplicate items; "Not Found: This object no longer exists" #22643

Open SgtMustang opened 3 years ago

SgtMustang commented 3 years ago

When a store is taken down and placed back up by a user, the previous listings tend to remain in our server's trade list and don't seem to ever go away on their own. This leads to duplication which clutters up the list significantly, and also does not appear to reflect the latest prices/stocks. See image below.

Store Bug Example

Thanks!

Azzurite commented 3 years ago

This is really annoying. It's also the case for all tooltips of items, not only the trade list.

Daniel-Magulado commented 3 years ago

Hello @SgtMustang and @Azzurite

Thank you for writing this bug report. Could you provide us with more information? Kindly upload a screenshot of the issues here, and a recorded video too if you have time. Then please also upload the name of the server that you are playing on, game logs, and server logs if possible. Additionally, if you're playing on a friend-hosted server that's not for the public, please let us know. We would also appreciate it if you can upload here a saved file of your world where the issue is happening or you can email it to me at daniel@strangeloopgames.com.

Azzurite commented 3 years ago

I don't know which circumstances exactly make it happen. I've seen it on every server I've played on so far, though. Currently I'm playing on "EcoWorld", but it also happened on the official servers "Giant Panda" and "White Tiger". Right now, when I pick up my store and place it down again, it correctly gets rid of the old store and doesn't create a "ghost" store, but it did before. Maybe it has something to do with circumstantial load.

A restart gets rid of these ghost stores, so I would assume that uploading a save file wouldn't help at all, since to load it in, the server has to be off. I'll ask the server owner of "EcoWorld" to upload some server log files, maybe that would help.

Here's a screenshot: image "Auto MortStone" was how my shop was named a day ago. The old "ghost" store seems to even update when new items are added/removed - the basic upgrade was not in there at the beginning.

Doubt it helps, but my Player.log

Daniel-Magulado commented 3 years ago

Hello,

Thank for providing more information. I've created an internal report about this issue. We currently have a similar report but it does not contain any information about the Economy viewer although the issue is quite similar. Unfortunately, we are having difficulties on trying to replicate this issue thus any additional information or documentation that both of you could provide is highly appreciated.

Azzurite commented 3 years ago

Another bit of info: the ghost store doesn't actually get added when I pick up a shop and place it down again, but some time later.

I did tests on the "EcoWorld" server when I wrote my previous comment and couldn't replicate it. However, after I logged back in 30 mins later or so, I had ~10 duplications of my store, all "not found". So I would assume that some periodic task that runs on stores is causing this.

MonzUn commented 2 years ago

This can be realiably reproduced by picking up a store with existing offers and placing it again and it's still an issue that occurs with high frequency and to much annoyance.

The only way to fix it is to restart the server.

MonzUn commented 2 years ago

I fixed this bug today and I'm submitting a PR. The repro is:

  1. Set up a store and list a valid store offer.
  2. Pick up the store.
  3. Place the store.
  4. Change the Price, limit or surability.
  5. Notice that the economy viewer now lists the offer twice.