StrangeLoopGames / EcoSuggestions

Repo for storing Eco game suggestions, separate from EcoIssues
34 stars 1 forks source link

Change wording for chat tabs #1694

Open CrazyFluffyPony opened 1 year ago

CrazyFluffyPony commented 1 year ago

image

Current label Better label Comment
Hide Ignore This action prevents any message of this channel to show up in the UI, except for when you "unhide" it, so it acts more like a block/ignore function
Delete Unpin This does not remove the channel and messages, instead it just unpins that channel, but if you would receive a new message on this channel, the channel would pop up again and show on the UI (opposite behavior compared to what "Hide" does)
D3nnis3n commented 1 year ago

The naming was done in relation to the visible chat channel handler, from which the channel is indeed hidden or removed, so I'm not sure I agree with you, rather thinking that this will overcomplicate it. In any case it is not a bug, as the wording is intended, so I'm going to move this over to the suggestion tracker.

CrazyFluffyPony commented 1 year ago

@D3nnis3n clarified the request.

I played Eco for over 1400 hours, and for me this was unexpected behavior. I unknowingly ignored/blocked players DM's. How do you expect a newcomer (<200 hours) to react?

Note: when you moved this issue, the original issue became kind of invisible, and i thought it was gone. I know it is a Github problem, maybe you find a way to improve this process, cheers!

D3nnis3n commented 1 year ago

I think there might be a further misunderstanding - the thing you screenshotted is not a channel, but a tab containing a DM channel in that specific case, other tabs can contain multiple channels as sources of messages, for example. (Channels are created via the bubble icon in chat header on the top right)

Ignoring a player is actually done via the /ignore command, so naming the action ignore would not be the right term for it and can be confused with the actual method to do so. It does what it says though, hiding the messages of that source. The /ignore function goes beyond that.

For the unpin I could agree, though "Delete" for me personally is not misunderstandable either, as it does what you expect it do in that moment, removing the tab. It getting re-added when you get a new message is expected behaviour, but unpin could be used - in that case we'd probably need to describe on how you can manually pin it again though.

As for moving the issue - when I wrote a comment notifying you about the move you should have received an e-mail if you follow the issue. Other than that, GitHub doesn't really offer anything to remedy that situation, unfortunately.

CrazyFluffyPony commented 1 year ago

mmh, yeah, complicated.

The thing is, when i click "hide" on a DM tab, if that player sends me another DM, it will not be shown to me at all (normally, if he sends me a DM, it will create a new tab and make it flash blue).

But you are right, "ignore" would be the wrong wording, since the "real ignore" already exists (i didn't know that exists)

So, yes it is "hiding" it, but ... forever. Which is unexpected, i think


Then its a github mailgun problem, or a preference, so my bad.

D3nnis3n commented 1 year ago

I still worked on my post and just edited it for the unpin one where we could easily agree, so might want to re-read that part if you haven't seen it yet.

Any idea for renaming the hide one without colliding with our player ignore function?

CrazyFluffyPony commented 1 year ago

"unpin" -> yep works for me

i do see the use case for "hiding" a channel (because you might need it later and want to unhide it, and you don't want it to become visible until then). However i do not see the use case for a DM to be hidden and DM's to be completely ignored (if i want to ignore it, i will use the /ignore function)

I think custom made channel tabs and DM tabs should be handled differently: For custom made channel tabs, keep the current behaviour For DM tabs, remove the "hide" option and optionally rename the "delete" option to "close"

D3nnis3n commented 1 year ago

That would be a major refactor unfortunately, hence had hoped for something we can do quickly - doing that is not currently supported in the system and hence would be something far out.

CrazyFluffyPony commented 1 year ago

yeah, 90% work for the 10% of functionality...

Otherwise i cannot think of any naming that would fit all situations (without being able to set different wording for channel tabs and DM tabs). In this case, you will have to close this little edge case issue.