search

StrangeLoopsAudio / gRainbow

A synthesizer that uses pitch detection to choose candidates for granular synthesis or sampling.
GNU General Public License v3.0
198 stars 6 forks source link

BUG: clicking on next candidate crashes VST3 #60

Closed AtmanActive closed 1 year ago

AtmanActive commented 1 year ago

Hi,

First of all, please let me congratulate you on developing this awesome software. This is absolutely fantastic. I'm blown away by what this synth does. Incredible!

Now, when I was testing the x64 windows VST3 version in Reaper, everything was working flawlessly but I did manage to discover a bug / unhandled exception. When editing a pad, by clicking on the little asterisk above it and clicking on layer <> arrows that were displaying 1/6, the plug-in crashed, taking the Reaper down with it. I presume that this is due to the fact that I didn't have additional layers enabled on this pad, so the plug-in tried to switch to the next layer which wasn't there.

Just wanted to let you know. Anyway, now I know to avoid those buttons.

Thank you for this VST gem.

bboettcher3 commented 1 year ago

Thanks for the report! I've gotten this from another user as well, so I'll try and track down the reason soon. By the way, the left/right arrows will change the position candidate (see the terminology section on its page), not the generator selected, you can instead click on the generator itself to change its parameters

AtmanActive commented 1 year ago

Yeah, I was wondering how to alt/random the candidates.

Just thinking out loud here, maybe it would be useful to have global <> buttons/selectors to be able to switch the candidates on the fly, while performing (shifting maybe?).

In any case, thank you for this awesome software and keep up the good work!

bboettcher3 commented 1 year ago

@AtmanActive could you send me the audio file/preset that would produce this crash?

AtmanActive commented 1 year ago

Coka Vox GRainbow Synth - Promene Refren.zip

Here it is.

AtmanActive commented 1 year ago

gRainbow_crash

bboettcher3 commented 1 year ago

@AtmanActive I can't seem to reproduce this even with your file using reaper, could you try the most recent build to see if it's still happening for you? Hoping it might have been fixed with some other changes. https://github.com/bboettcher3/gRainbow/actions/runs/5239813157

AtmanActive commented 1 year ago

Same behavior even with the latest build you referenced above.

Let me know if I can help you debug in any way.

AtmanActive commented 1 year ago

I just did a test with a brand new, fresh portable installation of the latest Reaper version for windows x64 and the behavior is the same.

AtmanActive commented 1 year ago

Crashing on my desktop machine where Reaper is running at 48kHz, but also crashing on my studio machine where Reaper is running at 192kHz.

bboettcher3 commented 1 year ago

Hmm, definitely something weird happening. I can only reproduce it when running the Release build, not in Debug.. which makes me think it's running into some sort of race condition somewhere. I'll try some things out...

AtmanActive commented 1 year ago

Can confirm: these problems are now gone in v0.4.0. Great work! Thank you very much for this brilliant synth/sampler.

bboettcher3 commented 1 year ago

Great! I'll close this, feel free to re-open it if it comes back at all.