search

Stranger6667 / jsonschema-rs

JSON Schema validation library
https://docs.rs/jsonschema
MIT License
511 stars 91 forks source link

fix: Ignoring $schema in resolved references #498

Closed Stranger6667 closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 96.75325% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (9c12d24) to head (dcdfa66). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
jsonschema/src/lib.rs 28.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ========================================== - Coverage 90.05% 90.01% -0.05% ========================================== Files 58 58 Lines 9866 9894 +28 ========================================== + Hits 8885 8906 +21 - Misses 981 988 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #498 will degrade performances by 22.35%

Comparing dd/fix-metaschema (dcdfa66) with master (9c12d24)

Summary

⚡ 26 improvements ❌ 1 regressions ✅ 293 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/fix-metaschema Change
⚡ additional_properties_false [jsonschema/is_valid/valid] 360.6 ns 302.2 ns +19.3%
⚡ additional_properties_false foo1[jsonschema/is_valid/invalid] 391.7 ns 333.3 ns +17.5%
⚡ any_of 1[jsonschema/is_valid/valid] 669.4 ns 581.9 ns +15.04%
⚡ any_of_multiple_types foo[jsonschema/is_valid/valid] 853.6 ns 736.9 ns +15.83%
⚡ any_of_multiple_types null[jsonschema/is_valid/invalid] 854.4 ns 737.8 ns +15.81%
⚡ boolean_false 1[jsonschema/is_valid/invalid] 58.9 ns 29.7 ns +98.13%
⚡ const 1[jsonschema/is_valid/valid] 450.6 ns 392.2 ns +14.87%
⚡ const foo[jsonschema/is_valid/invalid] 298.6 ns 269.4 ns +10.82%
⚡ format_email test@test.com[jsonschema/is_valid/valid] 595.6 ns 537.2 ns +10.86%
⚡ format_hostname not_a_valid_host_name[jsonschema/is_valid/invalid] 849.4 ns 761.9 ns +11.48%
❌ items 123[jsonschema/validate/valid] 4.1 µs 5.2 µs -22.35%
⚡ maximum 3[jsonschema/is_valid/valid] 360 ns 301.7 ns +19.34%
⚡ maximum 5[jsonschema/is_valid/invalid] 360 ns 301.7 ns +19.34%
⚡ minimum 1[jsonschema/is_valid/invalid] 301.7 ns 272.5 ns +10.7%
⚡ minimum 5[jsonschema/is_valid/valid] 301.7 ns 272.5 ns +10.7%
⚡ multiple_of_integer 125[jsonschema/is_valid/valid] 951.1 ns 863.6 ns +10.13%
⚡ multiple_of_integer 212.4[jsonschema/is_valid/invalid] 453.3 ns 395 ns +14.77%
⚡ multiple_of_integer 212[jsonschema/is_valid/invalid] 898.3 ns 810.8 ns +10.79%
⚡ not 1[jsonschema/is_valid/valid] 633.6 ns 516.9 ns +22.57%
⚡ not null[jsonschema/is_valid/invalid] 633.6 ns 516.9 ns +22.57%
... ... ... ... ...


:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.