StrataSource / Engine

Issue tracker for Strata Source
47 stars 2 forks source link

func_ladder is not functional #1196

Open MyGamepedia opened 1 year ago

MyGamepedia commented 1 year ago

Describe the bug

In P2CE (also in Portal 2) func_ladder is not functional.

Half Life: Source.

https://github.com/StrataSource/Portal-2-Community-Edition/assets/103366204/b8988d42-eb45-49b9-a8bc-6f08ff994b2d

P2CE.

https://github.com/StrataSource/Portal-2-Community-Edition/assets/103366204/5c92b0d5-0e81-4f15-a596-b871ba3a3487

Issue Map

Any with func_ladder.

To Reproduce

  1. Open my map for quick test. func_ladder_test.zip
  2. Сome to the ladder.
  3. Pay attention that nothing happen.

Operating System

Any.

ozxybox commented 11 months ago

Closing, as compat with HL:S is not planned.

MyGamepedia commented 11 months ago

Closing, as compat with HL:S is not planned.

However this entity avaible in P2CE.

Equalizer5118 commented 11 months ago

Applying the ladder tooltexture to a world brush works as normal. P2ce was built off of csgo, remember, and that is how it worked in csgo.

SirYodaJedi commented 3 months ago

Func_ladder is supposed to turn any texture into CONTENTS_LADDER, just like the %compileladder parm in toolsinvisibleladder; how it behaves in CSGO is a VBSP bug.

SirYodaJedi commented 3 months ago

Okay, upon further investigation, it seems how func_ladder works changed in L4D/L4D2, with it being kept as a brush and converted to func_simpleladder instead.

Since func_simpleladder doesn't exist in P2CE (and really doesn't need to), I do think that func_ladder should be reverted back to how it works in Source 2013 games, being basically just a func_detail that applies ladder contents.

Probably should apply detail contents as well, since it cuts visleaves otherwise (which are useless unless the brush is translucent), and maybe omit the unused info_ladder.

ozxybox commented 3 months ago

It seems like func_simpleladder doesn't exist in CS:GO, Portal 2, etc., so it's exclusive to L4D1/L4D2. Does func_ladder function in Portal 1 or TF2?

SirYodaJedi commented 3 months ago

Does func_ladder function in Portal 1 or TF2?

TF2 lacks ladders. I just checked Portal 1 (VMF+BSP here), and it's like HL2, where func_usableladder works, but brushes with CONTENTS_LADDER do nothing.

Func_ladder is used in CS:S and DoD:S, where it works the same as if you make the ladders CSGO-style.

ozxybox commented 3 months ago

Given this applies to CS:S compat, I’ll move this to the engine repo and allow someone from momentum mod to decide its fate, haha