StrataSource / FGD

The FGD + Hammer resource files for games built on Strata Source.
20 stars 15 forks source link

Fix logic_compare #112

Closed braem closed 2 years ago

braem commented 2 years ago

Spen was smart and added MBase & engine tags to these kvs, since (I assume) mbase was just exposing some things that already existed in game.

When we removed mbase tags here, engine wasnt also removed. We have this from mbase though!

Also exposes strlenallowed field which uses the length of the string of the compare value rather than its actual value. Seems a little useless (imo) but it exists in the game so lets be consistent.

braem commented 2 years ago

logic_case also had one that was incorrectly ported. Sorted through the HL2 and MBase tag removal PRs and couldnt find any more cases - only an issue with those since we have some of their entities.

TeamSpen210 commented 2 years ago

The reason for the engine tag here is actually something different - I need a single data type for each keyvalue/i/o in an entity for the engine export. That's used by the postcompiler to do autopacking among other things (perhaps instance collapsing in the future). In this case there's a conflict, so I add the engine tag to indicate the string ones should be prioritised.

braem commented 2 years ago

The reason for the engine tag here is actually something different - I need a single data type for each keyvalue/i/o in an entity for the engine export. That's used by the postcompiler to do autopacking among other things (perhaps instance collapsing in the future). In this case there's a conflict, so I add the engine tag to indicate the string ones should be prioritised.

ohh, would this break the engine compile then?? I'm a little skeptical it is fully functional in this repo in the first place though..

TeamSpen210 commented 2 years ago

No, since we now have only a single definition for each output it's fine.