search

StrataSource / FGD

The FGD + Hammer resource files for games built on Strata Source.
19 stars 13 forks source link

Cherry-pick upstream's master #130

Closed braem closed 2 years ago

braem commented 2 years ago

Closes https://github.com/ChaosInitiative/Chaos-FGD/issues/85

Taking over from https://github.com/ChaosInitiative/Chaos-FGD/pull/93 as that hasn't seen traction in awhile. This only includes changes in master, not spen's dev branch. Last commit being on January 12, 2022.

Changes intentionally not included:

Things we already have

Now I see that there are a couple commits (https://github.com/TeamSpen210/HammerAddons/commit/b76fd5ff58ae011278b1c4648cc9bcd6e4d34253 & https://github.com/TeamSpen210/HammerAddons/commit/7fbaedcfb1b39391b6748391ce416865192c8f59) that seem to suggest studioprop is mainly for older games.. if that is the case we should replace them all with studio?

A big commit I skipped over that needs special mention is one adding mapbase stuff https://github.com/TeamSpen210/HammerAddons/commit/e800a03571614015c07c455ef211f1f1e2b7e86e. We should add this to Chaos at some point (if mapbase is compatible with our license???)

braem commented 2 years ago

Also worth noting that this reverts the readme to that on spen's repo. We haven't had a Chaos-specific readme anyways. We need to write one!

tmob03 commented 2 years ago

A big commit I skipped over that needs special mention is one adding mapbase stuff TeamSpen210@e800a03. We should add this to Chaos at some point (if mapbase is compatible with our license???)

https://docs.momentum-mod.org/entity/mapbase_enhancements/ Some mapbase things are already in momentum

TeamSpen210 commented 2 years ago

studioprop() isn't for older things, basically you want studioprop() for props representing the "real" appearance of ents, studio() for editor helpers and the like. studio() doesn't include the model in the bounding box, and some other things like that.

braem commented 2 years ago

A big commit I skipped over that needs special mention is one adding mapbase stuff TeamSpen210@e800a03. We should add this to Chaos at some point (if mapbase is compatible with our license???)

https://docs.momentum-mod.org/entity/mapbase_enhancements/ Some mapbase things are already in momentum

Yup and we have the things we do have in FGDs currently. We just need to pull in the newer mapbase stuff at some point.

braem commented 2 years ago

studioprop() isn't for older things, basically you want studioprop() for props representing the "real" appearance of ents, studio() for editor helpers and the like. studio() doesn't include the model in the bounding box, and some other things like that.

Ah thanks for the heads up! <3

AWildErin commented 2 years ago

Unrelated to what the PR is bringing in, but I noticed it brought over changes for fgd/bases/BMBaseHelicopter.fgd, do we even need this file? It seems to a Black Mesa Source related thing

braem commented 2 years ago

Unrelated to what the PR is bringing in, but I noticed it brought over changes for fgd/bases/BMBaseHelicopter.fgd, do we even need this file? It seems to a Black Mesa Source related thing

Oh yeah I dont see any entity basing off it as well so I will remove here

braem commented 2 years ago

From a quick glance this seems fine to me

Yeah a lot of minor tweaks. Not really a need to go into the new comp entities or scripts that spen's working on nor any of the materials.