search

StrataSource / FGD

The FGD + Hammer resource files for games built on Strata Source.
20 stars 15 forks source link

USE_AI Tag for AI entities #132

Closed tmob03 closed 2 years ago

tmob03 commented 2 years ago

Also removed ai_addon and ai_addon_builder as they are left-overs from valve experiments not implemented in game but left in the FGD. Info_remarkable removed as it's very l4d focused like env_outtro_stats, can be removed from C++ in my opinion.

AWildErin commented 2 years ago

Also removed ai_addon and ai_addon_builder as they are left-overs from valve experiments not implemented in game

We do actually compile both of them in. Granted ai_addon_builder is compiled when hl2 entities are. Whether we should or not is another question, but it is something we have in Chaos.

edit: info_remarkable is also compiled in to Chaos, however I feel we could probably remove that from the engine.

tmob03 commented 2 years ago

We do actually compile both of them in. Granted ai_addon_builder is compiled when hl2 entities are. Whether we should or not is another question, but it is something we have in Chaos.

Oh, hmm didn't get either with ent_info_datatable in momentum mod, couldn't test in p2ce as I don't have it. Do they actually do anything? https://developer.valvesoftware.com/wiki/Ai_addon_builder The VDC page implies it's broken/not implemented as "This code has never been released to the public or used in its entirety in a Valve title." Is the modular AI system implemented in Chaos?

AWildErin commented 2 years ago

Not sure if it's implemented fully, since we don't particularly use it, but I'm just letting you know that we do have them in Chaos, but I'm not sure if we're ever going to use it. So if the consensus is that we're going to remove them, the licensee can probably go ahead and remove them from C++ aswell

braem commented 2 years ago

I'd like to start conversation about whether info_remarkable and ai_addon* are used or even functional. If not then we can yeet em in the codebase. To get in all this other great work though it might be best to leave those to later and remove them when we have a decision.

tmob03 commented 2 years ago

I'd like to start conversation about whether info_remarkable and ai_addon* are used or even functional. If not then we can yeet em in the codebase. To get in all this other great work though it might be best to leave those to later and remove them when we have a decision.

info_remarkable is used, but only in l4d. It's very specific to l4d as far as I can tell, it's used to make survivors speak when looking at them.

ai_addon entities I doubt is used and I doubt functional, at least it hasn't been in any source game. Valve made it in 2007 early in development for Portal 2. It was part of Valve's "Directed Design Experiments" It was the 2nd of the experiments and it did this: "Their experiment consisted of Overwatch Soldiers having different chips on their uniforms that would activate abilities such as flying and super-speed. A player would shoot an enemy, who would be blown to pieces, but with a twist: Another enemy would then run over, find stray ability chips other soldiers would have dropped, and would upgrade their abilities on the spot." from: https://halflife.fandom.com/wiki/Directed_Design_Experiments

tmob03 commented 2 years ago

Fixed merge conflicts ^

tmob03 commented 2 years ago

@braem Before this gets merged, are npcs planned at all in momentum's campaign/learn section? Some things I wasn't sure on adding into USE_AI was scripted_sentence, scripted_sequence, logic_chreographed_scene, etc. Animation entities that can control NPC animations and dialogue.

braem commented 2 years ago

@braem Before this gets merged, are npcs planned at all in momentum's campaign/learn section? Some things I wasn't sure on adding into USE_AI was scripted_sentence, scripted_sequence, logic_chreographed_scene, etc. Animation entities that can control NPC animations and dialogue.

Definitely not in learn. I'm not sure how much we can divulge about the campaign but those are safe to remove for now. We'll revisit them should we need them.