StrataSource / FGD

The FGD + Hammer resource files for games built on Strata Source.
20 stars 15 forks source link

Change all appliesto(P2CE) to appliesto(SINCE_P2CE) #174

Open StefanH-AT opened 1 year ago

StefanH-AT commented 1 year ago

This doesn't change any behavior for P2CE but allows Portal: Revolution to extend P2CEs features

ozxybox commented 1 year ago

Should this just be called PORTAL2_BASE, P2CE_BASE, PORTAL2, or other such?

The name SINCE_P2CE feels a bit odd, especially since it’s past tense and not a game name.

TeamSpen210 commented 1 year ago

Yeah, the right way is to add P2CE to the FEATURES dict, so it'll include that tag too.

StefanH-AT commented 1 year ago

P2CE is in the features dict https://github.com/StrataSource/Chaos-FGD/blob/master/unify_fgd.py#L49

TeamSpen210 commented 1 year ago

I mean to add "REVOLUTION": ["P2CE", ...].

StefanH-AT commented 1 year ago

How would this work? I currently have it set up like this and I can't see how I'd apply your suggestion image

TeamSpen210 commented 1 year ago

I mean you should add "P2CE" to the Revolution set. Then that tag will be set also when exporting for Revolution. You could also just edit your command line to be something like unify_fgd.py export P2CE REVOLUTION, so it'll include all the tags both have.

StefanH-AT commented 1 year ago

If I add the P2CE tag will that not inherit all feature flags P2CE has? I don't need all those

JJL772 commented 1 year ago

I'd create a group called PORTAL2 and include everything that's common between revo and p2ce in there.