Closed tmob03 closed 1 year ago
Please drop the merge commit and use rebase instead. (We should probably document that we use rebase somewhere...) Otherwise this PR is good to merge!
Oh sorry, got excited to hit merge too early. There’s a conflict, so I can’t merge the branch. You’ll need to rebase this onto the master branch.
Yeah sorry, first experiences with git cli, force pushed too early 😦
Since the fall off kvs are in their own base now,
light_directional
andlight_environment
now have keyvalues from BaseLight. A quick check in game shows these are indeed on both of these entities, so should work!Resolves #180 Resolves #181