search

StrataSource / FGD

The FGD + Hammer resource files for games built on Strata Source.
19 stars 13 forks source link

`func_illusionary` should not contain `solid` keyvalue #78

Open VortexParadox opened 2 years ago

VortexParadox commented 2 years ago

func_illusionary should not contain the solid keyvalue as this entity can not be solid in any way

braem commented 2 years ago

What keyvalues should it have? It inherits everything from its bases so it's quite ugly to remove. Or maybe add support to exclude a value from a base? Might encourage terrible inheritance though, and also would need changing in srctools I imagine.

VortexParadox commented 2 years ago

I'm just noticing func_wall and func_brush seem to outright ignore this key. What does this change and, in the case of func_brush, how is it different from Solid Type (solidbsp). Is this implemented?

VortexParadox commented 2 years ago

To me it looks like solid is a combination of solidity and solidbsp. But I don't know if it's currently conflicting and not working or if solid doesn't change anything

hexaflexahexagon commented 2 years ago

func_illusionary has these keyvalues in the TF2 fgd: image image

I'm just noticing func_wall and func_brush seem to outright ignore this key. What does this change and, in the case of func_brush, how is it different from Solid Type (solidbsp). Is this implemented?

Setting the solid type to BSP will mean that the bug where func_brush compiled to be 0.5 units smaller on every face than it was in hammer no longer happens, though I believe it also means that any func_brush that uses BSP collision cannot move. See https://github.com/momentum-mod/game/issues/719

tmob03 commented 2 years ago

Could make it read-only like func_areaportal and func_areaportalwindow's "Portal Version" keyvalue. Wouldn't stop people from changing it by turning off smartedit but would stop most. Would this be acceptable?

hexaflexahexagon commented 2 years ago

I'd probably prefer if it were just not visible completely as it still causes confusion and clutter. If that's determined to not be possible or feasible read only would work tho