StrataSource / Portal-2-Community-Edition

Task tracker for Portal 2: Community Edition
https://www.portal2communityedition.com
152 stars 3 forks source link

Feature: Make Static Props respect Adhesion color ConVar #1190

Closed ErinRoseWebs69 closed 2 months ago

ErinRoseWebs69 commented 2 years ago

Which component should be improved?

Entity

Describe your feature suggestion in more detail

If the color value of static props in the BSP file itself is a string and not in bytes, allowing static props to be able to read CVar values to define colors (namely for the gel pipes) would be useful for aesthetics.

if i make a map using adhesion gel, and one person's cvar is "0 255 0", while another person's is "255 0 175", allowing a static prop (again, namely gel pipes) to read that cvar and set its color to that cvar would make it so Person 1's gameplay shows the green pipe, while Person 2's gameplay shows the purple pipe. idk if im explaining this well.

this would only apply if the color value in static props are read as strings and not in bytes. im not gonna ask yall to rewrite the entire system for this.

TeamSpen210 commented 2 years ago

It's not a string, static props are in a special block, where all the data is highly compacted. They're 3 bytes specified directly. Instead a better method would be to recompile the paint pipes to add a 3rd skin, and in that skin have a material proxy reading the var or something. Or use a bit in the spawnflags, with CSGO there's a number free to use.

ErinRoseWebs69 commented 2 years ago

either method can work, whichever is easiest to implement without causing conflicts or something.

ozxybox commented 2 months ago

Closing as superseded by #1358