search

StrataSource / Portal-2-Community-Edition

Task tracker for Portal 2: Community Edition
https://www.portal2communityedition.com
146 stars 3 forks source link

Bug fix: Animations like Vactubes script don't animate in every frame.. but in Portal 2 it's fine apparently hmmm... #1591

Closed karl-police closed 7 months ago

karl-police commented 7 months ago

Describe

When I use Vactubes and uhhh

Vactubes do some kind of magic... so I needed to decode vactube script and like go through script and stuff but uhhh libraries, dependencies, it was kinda dank...

the cube in low framerate in P2:CE, kinda strange, I didn know really where Vactubes set attachment, so I took the generated animation and made it myself and I didn see change, I had to create cube myself to see and understand it

so I started looking and then I see sus value named AnimateEveryFrame image

so then... I did change in python script... https://github.com/TeamSpen210/HammerAddons/pull/251

I did, and I...

fixed

animateeveryframe=1

animateeveryframe is 0 by default when created through scripts and vactubes go on low frame rate cuz of this but not in Portal 2 apparently aaaaand

Issue Map

uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

https://github.com/TeamSpen210/HammerAddons/wiki/Vactubes

To Reproduce

🤓 well technically this issue is related to that animateeveryframe is not on 1 by default, so I don't have to mention Vactubes at all

  1. Create a prop_dynamic through a script 🤷
  2. uhhh in Python ctx.vmf.create_ent
  3. continue
  4. compare it to Hammer Editor by creating prop_dynamic

There it is on "Yes"

image

image

Operating System

No response

karl-police commented 7 months ago

Apparently it's not the right optimized fix, but it's still a solution