StrataSource / Portal-2-Community-Edition

Task tracker for Portal 2: Community Edition
https://www.portal2communityedition.com
146 stars 3 forks source link

sp_a1_intro3 portalgun pedestal makes a sound when TF2 is mounted (incorrect soundscript mount order) #1614

Open vrad-exe opened 7 months ago

vrad-exe commented 7 months ago

Describe the bug

The portal gun pedestal in sp_a1_intro3 makes a sound when rotating, which is not present in the original game.

Portal 2:

https://github.com/StrataSource/Portal-2-Community-Edition/assets/19228201/5f0e8ec1-8a77-49cf-8c2d-143cecaba78f

P2CE:

https://github.com/StrataSource/Portal-2-Community-Edition/assets/19228201/48adb811-9254-4d44-9676-5399edbbf7a4

To Reproduce

Self explanatory

Operating System

Tested on Windows 10

Equalizer5118 commented 7 months ago

Do you happen to have TF2 mounted? because that sounds like the default shutter door sound used in TF2.

I only have Portal 1 and HL2 installed, and I also hear sounds from the podium, but they sound like the rotating pedestal from Portal 1 instead of a door.

Fazlox commented 7 months ago

Sounds like metal_stop1.wav playing every time it rotates. That sound seems to be present in most Source games within their hl2 directories.

I imagine the pedestal could be using prop_door_rotating for its rotation? Maybe that entity changed somewhere between Portal 2 and P2CE in a way that makes it look for a default sound where it wouldn't have previously?

This may not be my place to make such input considering I don't have access to P2CE myself unfortunately, so I apologize if I'm just adding clutter to this.

TotallyKenzo commented 7 months ago

I can second this! Except I get the default door sfx (e.g. the portal 1 pedestal sound)

vrad-exe commented 7 months ago

The issue is that the default door sounds seem to have changed, the pedestal doesn't have any move sounds explicitly set. You can hear the same sounds playing here in one of my maps where the default sounds were previously used

https://github.com/StrataSource/Portal-2-Community-Edition/assets/19228201/5cceb104-149c-44f7-84cd-6e413c013af6

If I unmount TF2 as suggested above, the sounds go back to normal. So the issue seems to be that the mount priority for soundscripts is wrong, making TF2's soundscripts override Portal 2's even though it's in a lower searchpath.

Multiple people have said it plays the P1 pedestal sound for them, but I'm not sure how that would happen. P1 doesn't replace the default door sounds, and there's nothing else set to play the sound (the ambient_generic that played it in the P1 version of the map is still there, but never triggered)