search

Strategery-Inc / Magento2-InfiniteScroll

Automatically load the next page of products in Magento. Easy to install and configure, this module works 100% out of the box with vanilla Magento 2.x. For IAS license info: https://github.com/Strategery-Inc/Magento2-InfiniteScroll/issues/27#issuecomment-396148819
Academic Free License v3.0
57 stars 43 forks source link

Separated the external library from the AMD module and added a depend… #58

Closed joris-ati4 closed 4 years ago

joris-ati4 commented 4 years ago

This PR is related to the following issue: https://github.com/Strategery-Inc/Magento2-InfiniteScroll/issues/56

Sometimes the Infinite Ajax Scroll library is called before jQuery is loaded. The page then throws an error and the infinite scrolling doesn't work.

This PR, separates the Infinite Ajax Scroll library from the infinitescroll.js file because it is not recommended to include libraries in AMD module files. The shim also adds a dependency for the external library towards jQuery.

ihor-sviziev commented 3 years ago

Feels like this PR breaks bundling again that was fixed in past in https://github.com/Strategery-Inc/Magento2-InfiniteScroll/pull/52 image

I created https://github.com/Strategery-Inc/Magento2-InfiniteScroll/pull/69 for fixing this