search

Strategery-Inc / Magento2-InfiniteScroll

Automatically load the next page of products in Magento. Easy to install and configure, this module works 100% out of the box with vanilla Magento 2.x. For IAS license info: https://github.com/Strategery-Inc/Magento2-InfiniteScroll/issues/27#issuecomment-396148819
Academic Free License v3.0
57 stars 43 forks source link

Remove meaningless text #61

Closed ihor-sviziev closed 4 years ago

ihor-sviziev commented 4 years ago

This is follow up on https://github.com/Strategery-Inc/Magento2-InfiniteScroll/pull/37. Remove "Congratulations, you've reached the end of the internet." text. On production website it's better just not to add anything than adding such text.

Module should work fine out of the box and not add meaningless texts to existing pages.

ihor-sviziev commented 4 years ago

@gsomoza could you review my PR?

gsomoza commented 4 years ago

Thanks @ihor-sviziev , this makes sense – merged.

gsomoza commented 4 years ago

Do you need a release or can we wait a bit to see if there are other changes coming in?

ihor-sviziev commented 4 years ago

I think we can wait for other changes

On Tue, 11 Aug 2020 at 18:54, Gabriel Somoza notifications@github.com wrote:

Do you need a release or can we wait a bit to see if there are other changes coming in?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Strategery-Inc/Magento2-InfiniteScroll/pull/61#issuecomment-672037233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOJOUOJMLWJCRLTGJPUR33SAFSTXANCNFSM4OMB6RYA .