search

Stratus3D / asdf-lua

Lua plugin for asdf version manager. https://github.com/asdf-vm/asdf
MIT License
62 stars 12 forks source link

Luarocks installation fails on systems using parallel make #36

Closed Sharparam closed 5 months ago

Sharparam commented 5 months ago

If the number of "jobs" for make is by default set to something greater than 1, the make bootstrap step of installing Luarocks will fail, due to: https://github.com/luarocks/luarocks/issues/1638

Manually setting MAKEFLAGS="--jobs=1 before running make bootstrap works around the issue.

The maintainers of Luarocks seem like they will not fix it in upstream, so maybe it can be added in the install script of this plugin instead?

This affects any system where the default MAKEFLAGS is configured to anything greater than 1, for example systems that do the common thing of setting MAKEFLAGS="--jobs=$(nproc)".

Update: Looks like maybe there will be a fix upstream after all: https://github.com/luarocks/luarocks/pull/1663

If that PR is merged then this issue can be closed.

Sharparam commented 5 months ago

The PR has been merged, so this has now been fixed upstream.