Stratus3D / asdf-rebar

Rebar3/Rebar version management plugin for asdf
MIT License
35 stars 7 forks source link

Fetch pre-compiled rebar3 instead of building it locally #16

Closed kivra-pauoli closed 6 days ago

kivra-pauoli commented 1 week ago

This is a partial fix for #15, as well as (hopefully) issues with e.g. escript not being available at compile-time, as described in https://github.com/asdf-vm/actions/issues/585.

Advantages

kivra-pauoli commented 1 week ago

I'll also update CI to use asdf-vm/actions and thus replicate a real user situation (erlang installed via asdf plugin)...

Edit: was trying to update the tests to work around the scenario described over at https://github.com/asdf-vm/actions/issues/585, but ran into a similar issue: https://github.com/kivra-pauoli/asdf-rebar/actions/runs/10819613897/job/30017898426#step:5:46; the escript shim is available (https://github.com/kivra-pauoli/asdf-rebar/actions/runs/10819613897/job/30017898426#step:4:7152) but not even a reshim before rebar3 --version helps the test.

Edit: the workflow file for that run can be seen here.

Stratus3D commented 6 days ago

Thanks for the PR @kivra-pauoli ! Looks good to me. I'm going to do some testing and then merge later.

Stratus3D commented 6 days ago

Tested locally and seems good to me. And much faster!