search

StratusLab / client

Command Line Interface (CLI) for StratusLab cloud services
Apache License 2.0
2 stars 1 forks source link

Replace mechanize by urllib2 and add search function #145

Closed remyd1 closed 10 years ago

remyd1 commented 10 years ago

urllib2 is already required by stratuslab; so I removed mechanize because we do not need all the functions included in that package.

I also added the search function; it works, but I think it could be improved (when an image match with many criteras, do not display other images).

Regards,

Remy

loomis commented 10 years ago

@remyd1 Thanks for the contributions! Just a few things that may affect future contributions. We're moving to setuptools #146 so the organization of the CLI commands will change significantly. You can look in the 'setuptools' branch to see how things change. We'll also be adopting cliff (http://cliff.readthedocs.org/en/latest/) for an alternate (probably primary) interface. The list/show command would fit in nicely with the cliff framework. Lastly, it would be good to see how to incorporate these features into the Marketplace API classes.

remyd1 commented 10 years ago

Hi Cal,

I think I will let you make changes on the code I did to fit your new requirements (adding these features to API classes/marketplace (*)...), even if there is not a lot of modifications. I saw that you added encoding informations (utf-8) and a path to every sub-commands on 'setuptools' branch.

I will fork it again if needed, after these modifications. I thought about improving the search function for multi-critera by storing every corresponding sub nodes into a list of dictionnaries to display only the best answer (for the moment I show anything that matches at least one criterion).

Regards,

Rémy

(*) : I looked at the API class but that is not easy to understand when you do not write it yourself or when you do not have a class diagram or any documentation !