Closed PHPirates closed 5 years ago
This is the last thing I wanted to fix before "publishing": I wanted the build options in the .travis.yml instead of the tex-config.ini file.
Awesome! Thank you!
I just moved the actual options and changed the filename of the config file to .travis.yml: it seems that Travis accepts this as a valid yml file.
There is a bit more to it. Especially, parsing the .travis.yml
-file is not necessary. You can make the variables into environmental variables. I'll make a review and perhaps I'll fix it myself if I have time.
I tested locally that
execute_tests.sh
still picks up the options correctly, so I hope this works when compiled with Docker as well.
Testing is always awesome!
Any other things you want to have done? I think it works pretty good now.
I was thinking about #11 (To remove the need of travis-texbuild.sh
), but it's not a part of the quick start. I'll make the quick start the main branch before I move further.
I'll start on the review now and if I don't finish tonigh I'll finish tomorrow :)
Of course the Travis build for this repo fails, as it used the uploaded (old) docker images which searches for a tex-config.ini.
Edit: You can just do [skip ci] in your commit message/pull request message to skip travis! See skipping a build.
Again - thank you for the effort!
Doh, I knew about [ci skip] but somehow forgot it, thanks haha. My first thought was environment variables as well, but when I tried on my pc when I made a variable outside the docker image (like Travis would, I think) then when I was inside the running container I couldn't access the variable.
Anyway, yaml interpreter? You have mighty fancy ideas :smile: So the yaml parser would replace awk, basically? I understand it would be better though. We'll see who is first with investigating how this would work :stuck_out_tongue:
I guess this can work as a temporary solution though!
This is the last thing I wanted to fix before "publishing": I wanted the build options in the
.travis.yml
instead of thetex-config.ini
file. I didn't think it was necessary to make things complicated, so basically I just moved the actual options and changed the filename of the config file to.travis.yml
: it seems that Travis accepts this as a valid yml file. I tested locally thatexecute_tests.sh
still picks up the options correctly, so I hope this works when compiled with Docker as well. Any other things you want to have done? I think it works pretty good now.Of course the Travis build for this repo fails, as it used the uploaded (old) docker images which searches for a tex-config.ini.