StrawberryPerl / build-extlibs

16 stars 11 forks source link

libssh2 build status #14

Closed shawnlaffan closed 1 year ago

shawnlaffan commented 1 year ago

I've had a go updating libssh2 to use 1.10.0 and libssl to use 1.1.1q

Hopefully someone more knowledgeable about ssl/ssh can provide some input for how to proceed.

Source locations: https://www.libssh2.org/download/libssh2-1.10.0.tar.gz https://www.openssl.org/source/openssl-1.1.1q.tar.gz

The openssl change will also help with https://github.com/StrawberryPerl/Perl-Dist-Strawberry/issues/37 and https://github.com/StrawberryPerl/Perl-Dist-Strawberry/issues/31

The build process is successful except for two of the libssh2 test sets. See results below. The same test failures occur for the current version used in the build process (libssh2-1.8.2).

mansyntax.sh appears to run its tests successfully but throws an error when it fails to remove a working directory.

ssh2.sh cannot establish a session. Maybe this is due to an interaction with MSYS2/docker/windows?

# cat ./_bssh2__.src/libssh2-1.10.0/tests/test-suite.log
=====================================
   libssh2 -: tests/test-suite.log
=====================================

# TOTAL: 3
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: mansyntax.sh
==================

../tests/../docs/libssh2_agent_connect.3
../tests/../docs/libssh2_agent_disconnect.3
../tests/../docs/libssh2_agent_free.3
../tests/../docs/libssh2_agent_get_identity.3
../tests/../docs/libssh2_agent_get_identity_path.3
     [ ... snip lots of file names for brevity ... ]
../tests/../docs/libssh2_userauth_list.3
../tests/../docs/libssh2_userauth_password.3
../tests/../docs/libssh2_userauth_password_ex.3
../tests/../docs/libssh2_userauth_publickey.3
../tests/../docs/libssh2_userauth_publickey_fromfile.3
../tests/../docs/libssh2_userauth_publickey_fromfile_ex.3
../tests/../docs/libssh2_userauth_publickey_frommemory.3
../tests/../docs/libssh2_version.3
rm: cannot remove '../tests/man3': Is a directory
FAIL mansyntax.sh (exit status: 1)

FAIL: ssh2.sh
=============

command-line line 0: Deprecated option UsePrivilegeSeparation
command-line line 0: Deprecated option UsePrivilegeSeparation
Failure establishing SSH session
FAIL ssh2.sh (exit status: 1)
shawnlaffan commented 1 year ago

mansyntax.sh can be fixed by changing the rm -f to rm -rf.

shawnlaffan commented 1 year ago

It also appears MSYS2 are ignoring the test results. https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-libssh2/PKGBUILD#L52-L58

shawnlaffan commented 1 year ago

PR merged, so closing