search

StrawberryPerl / build-extlibs

16 stars 11 forks source link

build.sh cmd.exe call sometimes stays in the cmd shell #23

Closed shawnlaffan closed 1 year ago

shawnlaffan commented 1 year ago

Perhaps it is just my system, but it seems this call can sometimes stay in the cmd shell (or more correctly it starts a shell and waits for input).

https://github.com/StrawberryPerl/build-extlibs/blob/5323db5d6313a9584ed62511544de62adfa0538f/build.sh#L252

Exiting from the shell keeps the build process moving but obviously means the process cannot be run non-interactively.

Is the cmd call needed? It seems to be removing the readonly flag, which can be done using chmod -R u+w *. The line has been in the build system for more than 8 years so might be present purely for historical reasons.

genio commented 1 year ago

I think it's worth pulling it out if you can remove the flag without going into CMD.