search

StrawberryPerl / build-extlibs

16 stars 11 forks source link

Update netcdf source location #35

Closed hakonhagland closed 1 year ago

hakonhagland commented 1 year ago

This fixes issue #34 for me.

hakonhagland commented 1 year ago

Can you please alias the file like we do here?

@genio Yes that is a more maintainable solution. I have updated the PR.

genio commented 1 year ago

Does that build correctly without need for patching?

hakonhagland commented 1 year ago

Does that build correctly without need for patching?

@genio I started a new build now. It seems to download fine, here is the output from that part: 

[...]

### netcdf-c-4.9.0
2023-02-16 20:04:57 URL:https://codeload.github.com/Unidata/netcdf-c/tar.gz/refs/tags/v4.9.0 [19491744] -> "netcdf-c-4.9.0.tar.gz" [1
]
GONNA Apply: /z/extlib/patches/netcdf-c-4.9.0/0001-no-debug-libraries.patch : /z/extlib/_5034__/netcdf-c-4.9.0.patch.log
GONNA Apply: /z/extlib/patches/netcdf-c-4.9.0/0002-no-file.patch : /z/extlib/_5034__/netcdf-c-4.9.0.patch.log
GONNA Apply: /z/extlib/patches/netcdf-c-4.9.0/2460.patch : /z/extlib/_5034__/netcdf-c-4.9.0.patch.log

[...]

the build script has started to build packages, I guess it will take a while before it has finished.

shawnlaffan commented 1 year ago

Looks like the patching works.

FWIW, version 4.9.1 has recently been released. That version will not need the third patch (2460.patch) but MSYS2 is still using the other two (https://github.com/msys2/MINGW-packages/commit/8d0bb1753bb2b303ce02a299f06c0735ffb5a5ce). I'll look into it if I get a chance but it's not critical that we upgrade.